Reports by commit
Recent reports
Perl5 CoreSmokeDB
Github
Changes
Branch:
blead
maint-5.42
maint-5.40
maint-5.10
smoke-me/jkeenan/sync-win32-20260515
smoke-me/jkeenan/sync-io-socket-ip-20260515
smoke-me/tonyc/selfloader-mixed-io-again
smoke-me/jkeenan/sync-archive-tar-20260511
-- I want an older branch --
Reports for branch
maint-5.10
Show duplicate emailed reports
Filter:
?
Nicholas Clark: Eliminate (HV *) casts in u*.c.
C
Nicholas Clark: A gaggle of casts in Perl_sv_magicext() that are (const ?V *).
C
Nicholas Clark: Two casts that are MUTABLE_?V.
C
Nicholas Clark: A couple of (COP*)s that can actually be (const COP *)s.
C
Nicholas Clark: Add MUTABLE_HV(), and remove (HV *) casts from headers.
C
Nicholas Clark: Correct SvVALID() and SvTAIL() - they are actually const.
C
Nicholas Clark: MHX notes that I have a superfluous void cast.
C
Nicholas Clark: Convert all (CV *) casts to (const CV *). Convert (XPVCV*) casts to add MUTABLE_PTR(), to validate that there is no casting away of const.
C
Nicholas Clark: Add MUTABLE_AV(), and remove (AV *) casts from headers.
C
Nicholas Clark: Add a macro MUTABLE_PTR(p), which on (non-pedantic) gcc will not cast away const, returning a void *. Add MUTABLE_SV(sv) which uses this, and replace all (SV *) casts either with MUTABLE_SV(sv), or (const SV *).
C
Marcus Holland-Moritz: Add PERL_ARGS_ASSERT_MEM_LOG_COMMON to S_mem_log_common().
C
Nicholas Clark: In S_mro_get_linear_isa_dfs(), add void casts to silence two warnings about "value computed is not used". Re-order the code to group operations on the isa hash with each other. Add a SvREADONLY_on() on the isa array if it is generated by P
C
Nicholas Clark: Build the isa cache from any linear ISA, rather than forcing the use of dfs. This avoids calling dfs on a C3 class (and all its parents), which won't break anything, but is more work than is needed.
C
Nicholas Clark: Need to free the isa lookup hash before rebuilding it.
C
Nicholas Clark: Create a direct lookup hash for ->isa() lookup, by retaining the de-duping hash used by S_mro_get_linear_isa_dfs(). Provide a new function Perl_get_isa_hash() to lazily retrieve this. (Which could actually be static if S_isa_lookup() and P
C
Nicholas Clark: Abolish the warning "Can't locate package %"SVf" for the parents of %s" which doesn't tell you anything you won't discover soon enough when you try to call a method. (Or haven't already been warned about when @ISA was linearised)
C
Jerry D. Hedden: Silence build warnings in universal.c From: "Jerry D. Hedden" <jdhedden@cpan.org> Message-ID: <1ff86f510805211015m5c59bbf5wf3a992e776b1c4c4@mail.gmail.com>
C
Nicholas Clark: Make the worst case error message for Perl_croak_xs_usage() consistent with stringifying a code reference.
C
Nicholas Clark: Add Perl_croak_xs_usage(), which reduces a lot of explicit calls of the form Perl_croak(aTHX_ "Usage %s::%s(%s)", "ouch" "awk", "eee_yow"); down to croak_xs_usage(cv, "eee_yow"); and refactor all the core XS code to use it. This adds () to
C
Rafael Garcia-Suarez: Prevent the tokenizer from segfaulting in debug mode when a FUNC token is forced From: "Rafael Garcia-Suarez" <rgarciasuarez@gmail.com> Message-ID: <b77c1dce0805160313r78cb1b2bxfeb64460d2e9a7df@mail.gmail.com>
C
David Mitchell: todays merging activity
C
Jerry D. Hedden: Clean up unused 'popt' variable in perl.c From: "Jerry D. Hedden" <jdhedden@cpan.org> Message-ID: <1ff86f510804141307n583c159eqa94af3a2e6b141b4@mail.gmail.com> Date: Mon, 14 Apr 2008 16:07:42 -0400
C
Nicholas Clark: No need to copy the part of PERL5OPT that we've already scanned past.
C
Nicholas Clark: Very little const-propagation remains related to Perl_moreswitches().
C
Andy Dougherty: Re: Solaris build warnings Message-ID: <Pine.LNX.4.64.0803261337130.22919@fractal.phys.lafayette.edu>
C
Nicholas Clark: Define sv_insert() as a wrapper to sv_insert_flags(), and move Perl_sv_insert() to mathoms.c
C
Nicholas Clark: Add the correct argument assertion macro to sv_insert_flags(). Don't want anything wrongly marked as non-NULL slipping through.
C
Vincent Pit: Double magic with substr Message-ID: <47F119E8.5010106@profvince.com>
C
Steve Peters: Perl_croak_nocontext() is called with NULL indirectly from some XS-based modules.
C
Nicholas Clark: Assert that the av argument to all the av_*() functions is an array.
C
Steve Hay: Change variable name to fix debug build with PERL_OLD_COPY_ON_WRITE
C
Jan Dubois: Silence compiler warnings on Win32/VC6
C
Vincent Pit: doio.c:Perl_my_lstat:/* XXX Do really need to be calling SvPV() all these times? */ From: "Vincent Pit" <perl@profvince.com> Message-ID: <37048.147.210.17.175.1202998889.squirrel@147.210.17.175>
C
David Mitchell: update mergelog
C
Steve Hay: pp_system explicitly passes NULL to do_aspawn, so NULL must be "OK" *Now* my Win32 DEBUGGING build works :-)
C
Steve Hay: Drat. #33298 doesn't fix it: need this too. And even then I now get an assertion from win32.c line 628. Sigh...
C
Steve Hay: Correct another variable name in embed.fnc (Fixes my DEBUGGING builds on Win32)
C
Jan Dubois: Fix bit-fields for VC [was RE: [perl #50386] GIMME_V broken with 5.10.0/GCC and XS?] From: "Jan Dubois" <jand@activestate.com> Message-ID: <02ee01c8651b$17ef72f0$47ce58d0$@com>
C
David Mitchell: missed Porting/checkARGS_ASSERT.pl from previous commit
C
Nicholas Clark: assert() that every NN argument is not NULL. Otherwise we have the ability to create landmines that will explode under someone in the future when they upgrade their compiler to one with better optimisation. We've already done this at least
C
David Mitchell: undo some bleed-only embed.fnc parameter name renames
C
Nicholas Clark: The sv argument to gv_stashsv() is not NULL.
C
Nicholas Clark: Correct the paramter to Perl_op_xmldump(). The one that got away from change 33289.
C
Nicholas Clark: Correct (some) variable names in embed.fnc where they differ from the actual function declaration.
C
Nicholas Clark: In Perl_load_module_nocontext(), ver can actually be NULL. In Perl_hv_copy_hints_hv(), ohv can actually be NULL. In Perl_sortsv(), Perl_sortsv_flags() and S_qsortsvu(), array can be NULL (if the number of elements to sort is <= 1). In Perl
C
Nicholas Clark: Perl_sv_2iv_flags(), Perl_sv_2uv_flags, Perl_sv_2nv and Perl_sv_2pv_flags() all return 0/0/0.0/"" without warning given a NULL SV pointer so they ought to be marked as NULLOK in embed.fnc.
C
David Mitchell: run regen
C
Nicholas Clark: In Perl_sv_catpv(), Perl_sv_catpv_mg() the ptr can be not NULL. In Perl_sv_inc() and Perl_sv_dec(), the sv can be not NULL. In Perl_parser_dup() the proto parser can be NULL. In Perl_ptr_table_find(), the sought-for pointer can be NULL. In
C
Nicholas Clark: In Perl_regfree_internal(), rx is actually not NULL. In Perl_regnext(), p can actually be NULL.
C
Nicholas Clark: Perl_ck_retarget() doesn't even exist, so little point in mentioning it.
C
More...